feat(NODE-7043, NODE-7217, NODE-6793)!: adopt mongodb-client-encryption v7 #4705
Conversation
|
There is an existing patch(es) for this commit SHA: Please note that the status that is posted is not in the context of this PR but rather the (latest) existing patch and that may affect some tests that may depend on the particular PR. If your tests do not rely on any PR-specific values (like base or head branch name) then your tests will report the same status. If you would like a patch to run in the context of this PR and abort the other(s), comment 'evergreen retry'. |
|
superceded by #4694 |
|
There is an existing patch(es) for this commit SHA: Please note that the status that is posted is not in the context of this PR but rather the (latest) existing patch and that may affect some tests that may depend on the particular PR. If your tests do not rely on any PR-specific values (like base or head branch name) then your tests will report the same status. If you would like a patch to run in the context of this PR and abort the other(s), comment 'evergreen retry'. |
baileympearson
changed the title
baileympearson
force-pushed
the
NODE-7043-error-wrapper
branch
from
1c150e4 to
b67d4ef
Compare
dariakp
changed the title
baileympearson
force-pushed
the
NODE-7043-error-wrapper
branch
from
b67d4ef to
a70b1f5
Compare
| .catch(e => e); | ||
|
|
||
| expect(resultOrError).to.be.instanceOf(TypeError); | ||
| expect(resultOrError).to.be.instanceOf(MongoCryptError); |
There was a problem hiding this comment.
I don't have a better place to leave a comment, but we wanted to remove the custom matcher isMongoCryptError from the unified spec runner
dariakp
added
the
Primary Review
Description
Summary of Changes
This PR is a small feature branch containing the driver changes corresponding to breaking mongodb-client-encryption changes. It contains:
enableMultipleCollInfo(it now defaults to 'enabled')Warning
Do not merge this PR until all mongodb-client-encryption changes are completed, an alpha has been released, and this PR is updated to use the alpha.
Notes for Reviewers
The changes in mongodb-js/mongodb-client-encryption#102 must be released before CI passes fully. The custom dependency tests use the changes from my other PR and should be passing.
What is the motivation for this change?
Release Highlight
Release notes highlight
Double check the following
npm run check:lint)type(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript